Skip to content

fix(cli): Fix CLI compatibility issue with SDK response objects#161

Merged
luk384090-cloud merged 2 commits into
mainfrom
dev/sdk-cli-1
Jul 9, 2026
Merged

fix(cli): Fix CLI compatibility issue with SDK response objects#161
luk384090-cloud merged 2 commits into
mainfrom
dev/sdk-cli-1

Conversation

@luk384090-cloud

Copy link
Copy Markdown
Collaborator

Description

[Describe what this PR does and why]

Related Issue: Fixes #[issue_number] or Relates to #[issue_number]

Security Considerations: [Check if API keys or sensitive credentials are exposed in code/logs]

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation
  • Refactoring

Component(s) Affected

  • Model
  • Application
  • Common
  • Documentation
  • Tests
  • CI/CD

Checklist

  • Pre-commit hooks pass
  • Tests pass locally
  • Documentation updated (if needed)
  • Ready for review

Testing

[How to test these changes]

Additional Notes

[Optional: any other context]

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request replaces dictionary .get() calls with getattr() when retrieving fields from response objects across deployments.py, files.py, and fine_tunes.py. The reviewer pointed out that if these response objects are standard Python dictionaries, getattr() will fail because dictionaries do not expose keys as attributes. The feedback recommends safely handling both dictionary and object types by checking if the response is an instance of dict before falling back to getattr().

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread dashscope/cli/deployments.py Outdated
Comment thread dashscope/cli/files.py Outdated
Comment thread dashscope/cli/fine_tunes.py Outdated
Comment thread dashscope/cli/fine_tunes.py Outdated
Comment thread dashscope/cli/fine_tunes.py
@luk384090-cloud
luk384090-cloud merged commit 80998be into main Jul 9, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant